On 2021/02/08 10:54, Jonathan Gray wrote:
> On Sun, Feb 07, 2021 at 07:58:52PM +0100, Sven Wolf wrote:
> > Hi,
> >
> > I've added some Ryzen 3xxx, AMD 500 Chipset, Navi 10 and Kingston ids to
> > pcidev. I've taken the description from the Linux PCI device ids
> > https://pci-ids.ucw.cz/v2.2/pci.ids
The names don't match the entries in pci.ids:
> > +product AMD 17_3X_DEV_1 0x1440 17h/3xh Device 24
> > +product AMD 17_3X_DEV_2 0x1441 17h/3xh Device 24
> > +product AMD 17_3X_DEV_3 0x1442 17h/3xh Device 24
> > +product AMD 17_3X_DEV_4 0x1443 17h/3xh Device 24
> > +product AMD 17_3X_DEV_5 0x1444 17h/3xh Device 24
> > +product AMD 17_3X_DEV_6 0x1445 17h/3xh Device 24
> > +product AMD 17_3X_DEV_7 0x1446 17h/3xh Device 24
> > +product AMD 17_3X_DEV_8 0x1447 17h/3xh Device 24
>
> "Device 24"?
>
> I would expect desktop Ryzen 3xxx to be 17h/71h.
pci.ids has these as "Matisse Device 24: Function 0..7"
> > +product AMD 17_3X_IOMMU 0x1481 17h/3xh IOMMU
> > +product AMD 17_3X_PCIE_1 0x1482 17h/3xh PCIE
> > +product AMD 17_3X_GPP_1 0x1483 17h/3xh GPP
> > +product AMD 17_3X_GPP_2 0x1484 17h/3xh GPP
> > product AMD 17_3X_CCP 0x1486 17h/3xh Crypto
> > product AMD 17_3X_HDA 0x1487 17h/3xh HD Audio
1480 Starship/Matisse Root Complex
1462 7c37 X570-A PRO motherboard
1481 Starship/Matisse IOMMU
1482 Starship/Matisse PCIe Dummy Host Bridge
1483 Starship/Matisse GPP Bridge
1484 Starship/Matisse Internal PCIe GPP Bridge 0 to bus[E:B]
1485 Starship/Matisse Reserved SPP
1486 Starship/Matisse Cryptographic Coprocessor PSPCPP
> > product AMD 400SERIES_PCIE_2 0x43c7 400 Series PCIE
> > product AMD 400SERIES_AHCI 0x43c8 400 Series AHCI
> > product AMD 400SERIES_XHCI 0x43d0 400 Series xHCI
> > +product AMD 500SERIES_AHCI 0x43eb 500 Series AHCI
> > +product AMD 500SERIES_XHCI 0x43ee 500 Series xHCI
> > +product AMD 500SERIES_PCIE_1 0x43e9 500 Series PCI Bridge
> > +product AMD 500SERIES_PCIE_2 0x43ea 500 Series PCI Bridge
missing in pci.ids, but so is 43d0.
The new entries here are out of order.
> > +product ATI NAVI10_9 0x1478 Radeon RX5000
> > +product ATI NAVI10_10 0x1479 Radeon RX5000
>
> Where are these from? They are not matched in amdgpu.
1478 Navi 10 XL Upstream Port of PCI Express Switch
1479 Navi 10 XL Downstream Port of PCI Express Switch
