On Fri, 15 Jan 2021 11:37:47 -0500 Bryan Steele <bry...@gmail.com> wrote:
> On Fri, Jan 15, 2021 at 06:23:01AM -0700, Thomas Frohwein wrote: > > On Sat, Jan 09, 2021 at 10:16:16AM +0100, Marcus Glocker wrote: > > > On Thu, Jan 07, 2021 at 08:20:35PM +0100, Marcus Glocker wrote: > > > > > > > > I have heard from others who tried the diff that the PS4 > > > > > controller is causing problems with the way it attaches. I > > > > > ordered one to trial-and- error this myself at home. Could > > > > > you share output of lsusb -vv? Thanks for giving it a try! > > > > > > > > Sure, here we go. > > > > If I can find anything myself in the meantime I let you know. > > > > > > So the problem doesn't seem to be in your new ujoy(4) code, but > > > how the dev/hid/hid.c:hid_is_collection() function tries to cope > > > with the PS4 controller. > > > > So with the hid_is_collection() problem not easy to mitigate [1], > > should we table the ujoy(4) proposal for now pending a fix for the > > problems with the PS4 controller? Or is this interesting enough for > > some to work on moving forward despite this issue and finding a > > solution for this specific (and in some ways unusual) device later? > > > > Considering the hid_is_collection() fix from NetBSD proposed by Marcus > fixes the issue with ujoy(4) but breaks some other drivers (imt(4) > and ims(4)), could we not inline it into ujoy(4) for now? It's fairly > small helper function. Like hid_is_joy_collection()? I think that could be an XXX workaround until somebody finds a proper, generic fix for hid_is_collection() ...
