On Wed, Jan 13, 2021 at 9:38 PM Scott Cheloha <scottchel...@gmail.com> wrote: snip
> Do we need to properly set stathz for each platform in *this* diff? > Or can it wait? > > I was hoping to do a sweep of the tree in a later patch and ensure > that stathz is non-zero everywhere and simultaneously remove code like > this: > > int realstathz = stathz ? stathz : hz; > > Near as I can tell, stathz doesn't need to be nonzero for statclock() > to work correctly. Also, setstatclockrate() doesn't even run unless > stathz is non-zero, so there are no issues with the profiling clock > stuff yet. > > > This isn't to say that removing the stathz== 0 magic should not be done, > > but if done, make certain that stathz and profhz are properly > > updated/configured. > Every driver which is being modified to call both hardclock() and statclock() will need to be modified again to set stathz, then you will need to verify with the rest of the system that there is no other places that stathz init was previously forgotten. Therefore, why not correctly modify each driver now?
