On Fri, Sep 18, 2020 at 06:50:33AM -0600, Thomas Frohwein wrote:

Hello Thomas,

Thanks for your comments!

> It might be worth considering combining kern.audio.record and
> kern.video.record, as they serve the same purpose (just different
> modalities). I doubt that granular controls with separate switches will be
> very useful at this level; maybe rather leave this differentiation to the
> application?
>
> An added benefit would be that there would be less largely duplicated code;
> and probably better maintainability.

I agree that it would simplify the code. The reason that I didn't merge them
is because I know that sometimes people want to record audio but not video (I
doubt that many people record video without audio). Now, admittedly, this
isn't necessarily a super-common use case, so it might not be worth having
two knobs for it, but it might be worth considering. Personally I'm
completely comfortable with whatever the general consensus is for
merging/not-merging!


Laurie

Reply via email to