not helpful:
$ doas acme-client $(hostname)
acme-client: https://api.test4.buypass.no/acme-v02/new-acct: bad HTTP: 400
vomitting unformated json is not better:
$ doas acme-client -v $(hostname)
acme-client: transfer buffer:
[{"type":"urn:ietf:params:acme:error:malformed","detail":"Email is a required
contact","code":400,"message":"MALFORMED_BAD_REQUEST","details":"HTTP 400 Bad
Request"}] (164 bytes)
let's do this:
$ doas obj/acme-client -v $(hostname)
acme-client: Email is a required contact
OK?
diff --git extern.h extern.h
index 529d3350205..364425b0500 100644
--- extern.h
+++ extern.h
@@ -259,6 +259,7 @@ int json_parse_order(struct jsmnn *, struct order
*);
int json_parse_upd_order(struct jsmnn *, struct order *);
void json_free_capaths(struct capaths *);
int json_parse_capaths(struct jsmnn *, struct capaths *);
+char *json_getstr(struct jsmnn *, const char *);
char *json_fmt_newcert(const char *);
char *json_fmt_chkacc(void);
diff --git json.c json.c
index 61d2631359f..a6762eeb258 100644
--- json.c
+++ json.c
@@ -297,7 +297,7 @@ json_getobj(struct jsmnn *n, const char *name)
* that it's the correct type.
* Returns NULL on failure.
*/
-static char *
+char *
json_getstr(struct jsmnn *n, const char *name)
{
size_t i;
diff --git netproc.c netproc.c
index 7b8152196d1..05e36897c38 100644
--- netproc.c
+++ netproc.c
@@ -371,15 +371,27 @@ sreq(struct conn *c, const char *addr, int kid, const
char *req, char **loc)
static int
donewacc(struct conn *c, const struct capaths *p)
{
+ struct jsmnn *j = NULL;
int rc = 0;
- char *req;
+ char *req, *detail, *error = NULL;
long lc;
if ((req = json_fmt_newacc()) == NULL)
warnx("json_fmt_newacc");
else if ((lc = sreq(c, p->newaccount, 0, req, &c->kid)) < 0)
warnx("%s: bad comm", p->newaccount);
- else if (lc != 200 && lc != 201)
+ else if (lc == 400) {
+ if ((j = json_parse(c->buf.buf, c->buf.sz)) == NULL)
+ warnx("%s: bad JSON object", p->newaccount);
+ else {
+ detail = json_getstr(j, "detail");
+ if (detail != NULL && stravis(&error, detail, VIS_SAFE)
+ != -1) {
+ warnx("%s", error);
+ free(error);
+ }
+ }
+ } else if (lc != 200 && lc != 201)
warnx("%s: bad HTTP: %ld", p->newaccount, lc);
else if (c->buf.buf == NULL || c->buf.sz == 0)
warnx("%s: empty response", p->newaccount);
--
I'm not entirely sure you are real.
