Re: trunk: keep interface up on port removal

[Stuart Henderson]

This has been tried before, I forget what but there were problems

--
 Sent from a phone, apologies for poor formatting.
On 12 September 2020 21:16:31 Alexander Bluhm <alexander.bl...@gmx.net> wrote:

OK bluhm@

On Sat, Sep 12, 2020 at 05:49:52PM +0200, Klemens Nanni wrote:

Index: if_trunk.c
===================================================================
RCS file: /cvs/src/sys/net/if_trunk.c,v
retrieving revision 1.149
diff -u -p -r1.149 if_trunk.c
--- if_trunk.c  28 Jul 2020 09:52:32 -0000      1.149
+++ if_trunk.c  12 Sep 2020 15:41:14 -0000
@@ -423,10 +423,6 @@ trunk_port_destroy(struct trunk_port *tp
        /* Remove multicast addresses from this port */
        trunk_ether_cmdmulti(tp, SIOCDELMULTI);

-       /* Port has to be down */
-       if (ifp->if_flags & IFF_UP)
-               if_down(ifp);
-
        ifpromisc(ifp, 0);

        if (tr->tr_port_destroy != NULL)