On Mon, 7 Sep 2020 21:39:55 +0200 Marcus Glocker <[email protected]> wrote:
> On Mon, 7 Sep 2020 20:50:20 +0200 (CEST) > Mark Kettenis <[email protected]> wrote: > > > > Date: Mon, 7 Sep 2020 19:59:13 +0200 > > > From: Marcus Glocker <[email protected]> > > > > > > On Mon, 7 Sep 2020 19:25:00 +0200 (CEST) > > > Mark Kettenis <[email protected]> wrote: > > > > > > > > Date: Mon, 7 Sep 2020 12:02:15 -0500 > > > > > From: joshua stein <[email protected]> > > > > > > > > > > On Mon, 07 Sep 2020 at 06:58:01 +0200, Marcus Glocker wrote: > > > > > > > > > > > This is an initial driver for the Apple System Management > > > > > > Controller found in Intel based Apple computers. > > > > > > > > > > > > The driver is currently missing support for the Sudden > > > > > > Motion Sensor (SMS), light sensor, and keyboard backlight > > > > > > since I don't have that hardware available to develop on. > > > > > > > > > > > > On my iMac11,2 it can deliver fan and temperatures values: > > > > > > > > > > > > hw.sensors.acpiapplesmc0.temp0=24.00 degC (Airflow > > > > > > 1) hw.sensors.acpiapplesmc0.temp1=33.00 degC (CPU Core 0) > > > > > > hw.sensors.acpiapplesmc0.temp2=36.00 degC (CPU > > > > > > Heatsink) hw.sensors.acpiapplesmc0.temp3=40.00 degC (CPU > > > > > > Core 1) hw.sensors.acpiapplesmc0.temp4=47.00 degC (GPU) > > > > > > hw.sensors.acpiapplesmc0.temp5=45.00 degC (GPU > > > > > > Heatsink) hw.sensors.acpiapplesmc0.temp6=59.00 degC (PCH) > > > > > > hw.sensors.acpiapplesmc0.temp7=42.00 degC (Memory) > > > > > > hw.sensors.acpiapplesmc0.temp8=45.00 degC (Mainboard > > > > > > Proximity) hw.sensors.acpiapplesmc0.fan0=998 RPM > > > > > > hw.sensors.acpiapplesmc0.fan1=1132 RPM > > > > > > hw.sensors.acpiapplesmc0.fan2=1198 RPM > > > > > > > > > > > > Feedback, testers, OKs? > > > > > > > > > > Are there machines where asmc(4) will also attach? > > > > > > > > Good point. My old Macmini1,1 has: > > > > > > > > ... > > > > "APP0001" at acpi0 not configured > > > > ... > > > > asmc0 at isa0 port 0x300/32: rev 1.3f503, 137 keys > > > > ... > > > > > > > > So yes, I'd say there are. > > > > > > > > > > > > Having an acpi attachment is probably better than doing isa > > > > probes. But we probably should consolidate the drivers. > > > > > > D'oh! I wasn't even aware that we already have an asmc(4) driver > > > in our tree. Shame on me :-| > > > > > > Glancing over asmc(4) I don't think there is anything more that my > > > driver would support other than attaching over acpi(4). Would it > > > be possible to only write an acpi glue which attaches to asmc(4)? > > > > > > > I think we'd just want to turn it into an acpi(4) driver. Or maybe > > dump it in favour of your driver. > > Ok. I'll give it a try to convert asmc(4) in to an acpi(4) driver and > see how it works here. I can make asmc(4) attach through acpi(4) on my machine, but then it crashes with uvm fault because it doesn't seem to recognize my machine type, and tries to access a NULL pointer on 'sc_prod'. My approach was more to not relay on specific machine types, but just check what sensors are supported by the SMC and try to use them. I lack a bit motivation to add specific models to asmc(4) to be honest. One question just out of curiosity; When you use acpiapplesmc(4) on your iMac, does it support any sensors there, or even does it work at all? Thanks, Marcus
