Hi Mark, Mark Kettenis wrote on Thu, Jul 09, 2020 at 07:59:25PM +0200: > Ingo Schwrze wrote:
>> Now that i look at that, and at what you said previously, is it even >> plausible that some user ever wants "-t c" ktracing but does >> specifically *not* want to see clock_gettime(2) and friends? [...] > Yes. If I ktrace something like chromium I really don't want to see > the thousands of pointless clock_gettime(2) calls. Fair enough. Together with what deraadt@ explained, it probably is -T, then. >> Regarding the LD_ prefix, clock_gettime(2) and gettimeofday(2) >> are in <time.h> and <sys/time.h>, respectively, but maybe a TIME_ >> prefix would be too specific. Sure, it is the "time" sublibrary >> of libc, but "TIME_" wouldn't really make it apparent that it >> is related to libc at all. >> >> So, should it instead be something like: >> >> LIBC_KTRACE_GETTIME ? > I wonder if it should start with an underscore instead to indicate > that the variable is not for public consumption. _KTRACE_TIME would > do the job for me. We can always rename it if we discover another use > case apart from ktrace. Sounds like user interface is almost finished; _KTRACE_TIME sounds nicely concise, yet still properly specific. Yours, Ingo
