On 28/04/20(Tue) 01:54, Jonathan Gray wrote: > On Mon, Apr 27, 2020 at 04:52:33PM +0200, Martin Pieuchot wrote: > > Diff below extends the existing drmkqfilter() to support EVFILT_READ. > > This makes drm(4)'s kqueue support in pair with poll(). > > > > The event list queried in the filt_drmread() should be protected by the > > `event_lock' mutex. This could be done by using the `kdev' backpointer > > as shown in comment. However this would require some plumbing to make > > use of `minor'. The side effect of this approach would be to reduce the > > diff with Linux. > > You seem to be confusing kdev and dev in the drm_minor struct. > at least in linux kdev is 'struct device *' and dev is > 'struct drm_device *' (which has the event lock). > I have a tree which uses the drm_minor struct but it is part of a much > larger diff.
Thanks for pointing that out! Do you see another way to comply to the locking then? > Could you explain what prompted this diff? My on-going audit of the poll & kqueue interfaces to ensure they are coherent.
