On Wed, 01 Apr 2020 13:47:58 +0200 phi...@warpmail.net (Philip K.) wrote: > George Koehler <kern...@gmail.com> writes: > > > C-x C-j doesn't work for me: it does show the dired buffer, but > > doesn't jump to the file that I was editing. > > Looks like that was because I called gotofile before showbuffer. I > changed that before submitting it, and I remember it seeming to work, > but I guess I was mistaken :/ This patch should fix that though.
I built your diff from 1 Apr. Now C-x C-j does jump. In emacs, if I visit /tmp/nowhere/new, but /tmp/nowhere doesn't exist, then C-x C-j shows an error: | Setting current directory: No such file or directory, /tmp/nowhere/ In mg with your diff, if I do the same, then C-x C-j does nothing, and doesn't show an error. I would like to see an error. I don't need the exact same error message as emacs; but I want to know that mg got my command, and the command failed. (For people trying emacs, C-x C-j doesn't work until you load dired-x. An easy way to load dired-x is to visit any dir, then M-x dired-jump.) I didn't review all your code, but I now think that you should call xbasename() instead of basename(), to be consistent with the existing dired code. --George
