Hi,
The type of brightness and video_output is uint32_t; therefore it
can never be less than 0 (which is what HCI_LCD_BRIGHTNESS_MIN and
HCI_VIDEO_OUTPUT_CYCLE_MIN are defined to). So trim the checks by
removig the impossible cases.
Coverity CID 1453109, 1453169
OK?
Index: acpi/acpitoshiba.c
===================================================================
RCS file: /cvs/src/sys/dev/acpi/acpitoshiba.c,v
retrieving revision 1.12
diff -u -p -r1.12 acpitoshiba.c
--- acpi/acpitoshiba.c 13 Oct 2019 10:56:31 -0000 1.12
+++ acpi/acpitoshiba.c 11 Mar 2020 11:35:23 -0000
@@ -438,9 +438,8 @@ toshiba_set_brightness(struct acpitoshib
for (i = 0; i < HCI_WORDS; ++i)
args[i].type = AML_OBJTYPE_INTEGER;
- if ((*brightness < HCI_LCD_BRIGHTNESS_MIN) ||
- (*brightness > HCI_LCD_BRIGHTNESS_MAX))
- return (HCI_FAILURE);
+ if (*brightness > HCI_LCD_BRIGHTNESS_MAX)
+ return (HCI_FAILURE);
*brightness <<= HCI_LCD_BRIGHTNESS_SHIFT;
@@ -534,8 +533,7 @@ toshiba_set_video_output(struct acpitosh
bzero(args, sizeof(args));
- if ((*video_output < HCI_VIDEO_OUTPUT_CYCLE_MIN) ||
- (*video_output > HCI_VIDEO_OUTPUT_CYCLE_MAX))
+ if (*video_output > HCI_VIDEO_OUTPUT_CYCLE_MAX)
return (HCI_FAILURE);
*video_output |= HCI_VIDEO_OUTPUT_FLAG;
--
jasper
