Hi,

Mark Kettenis wrote:
> > Since we don't filter out hid_(end)collection, we add this item to the
> > list.  So, by making sure we only add hid_input items, the Pinebook
> > Pro's trackpad works.
> > 
> > Now I'm not sure if the hid code is supposed to re-use the Y-coordi-
> > nates usage on the next collection.  If someone knows how that should
> > work, please let me down.
> > 
> > ok?
> 
> Both hidms and hiskbd do something similar, so ok kettenis@

I'm new to this code, having looked at src/sys/ for the first time at
the u2k20 hackathon.

Anyway, it looks to me like hidmt is a little bit simplistic (that's
both good and bad) and with that in mind I think this change is fine.
While it might be desirable/neccessary to have a more comprehensive
software model of the connected HID in the future, FWIW right now this is
ok [email protected]


//Peter

Reply via email to