On Sat, Dec 28, 2019 at 03:23:51AM +0100, Klemens Nanni wrote:
> On Sat, Dec 28, 2019 at 01:14:17PM +1100, Jonathan Gray wrote:
> > drop the _PCIE and just have
> >
> > product SYMBIOS SSS6200
> Sure enough. I added it in analogy to other devices. What is the rule
> here for such suffix? Only when the same product/chip is available
> as PCI *and* PCIE model or so?
I don't think there are particular rules there, we just have to use
something to distinguish different IDs for the same device. Adding _PCIE
to this one doesn't really help, so I think it's better without.
ok jmatthew@
>
>
> Index: mpii.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/mpii.c,v
> retrieving revision 1.121
> diff -u -p -r1.121 mpii.c
> --- mpii.c 12 Sep 2019 22:22:53 -0000 1.121
> +++ mpii.c 28 Dec 2019 02:21:03 -0000
> @@ -413,6 +413,7 @@ mpii_dvatosge(struct mpii_sge *sge, u_in
> static const struct pci_matchid mpii_devices[] = {
> { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SAS2004 },
> { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SAS2008 },
> + { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SSS6200 },
> { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SAS2108_3 },
> { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SAS2108_4 },
> { PCI_VENDOR_SYMBIOS, PCI_PRODUCT_SYMBIOS_SAS2108_5 },
> Index: pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1902
> diff -u -p -r1.1902 pcidevs
> --- pcidevs 20 Nov 2019 16:33:00 -0000 1.1902
> +++ pcidevs 28 Dec 2019 02:20:53 -0000
> @@ -6195,6 +6195,7 @@ product SYMBIOS SAS2108_5 0x0077 SAS2108
> product SYMBIOS SAS2108_1 0x0078 MegaRAID SAS2108 CRYPTO GEN2
> product SYMBIOS SAS2108_2 0x0079 MegaRAID SAS2108 GEN2
> product SYMBIOS SAS1078DE 0x007c SAS1078DE
> +product SYMBIOS SSS6200 0x007e SSS6200
> product SYMBIOS SAS2208_1 0x0080 SAS2208
> product SYMBIOS SAS2208_2 0x0081 SAS2208
> product SYMBIOS SAS2208_3 0x0082 SAS2208
