On Fri, Sep 13, 2019 at 09:34:33PM +0200, Caspar Schutijser wrote: > Hi, >
Hi, > smtpd crashed on one of my machines. I attempted to start it again but > it crashed again after a few seconds. > > [...] > > So I think the problem is that b->backupname is passed to strcmp() > without checking whether b->backupname != NULL. The diff below adds > such a check, in line with other string comparisons that are performed > in mta_relay_cmp(). In the same function, I think the same problem > exists while comparing a->authlabel and b->authlabel so I added a > similar check there. > > I'd like you to double-check whether the fix is indeed correct. > Yes, your understanding of the problem is correct and your diff also, so I committed it a minute ago, thanks ! I'm curious about what configuration allowed you to hit this though, can you share your smtpd.conf with me ? -- Gilles Chehade @poolpOrg https://www.poolp.org patreon: https://www.patreon.com/gilles
