On Thu, Aug 22, 2019 at 10:27:38AM +0000, Rashad Kanavath wrote:
> update description of -s option in sysupgrade man page.
> 
> Index: usr.sbin/sysupgrade/sysupgrade.8
> ===================================================================
> RCS file: /cvs/src/usr.sbin/sysupgrade/sysupgrade.8,v
> retrieving revision 1.8
> diff -u -p -u -p -r1.8 sysupgrade.8
> --- usr.sbin/sysupgrade/sysupgrade.8 9 May 2019 21:09:37 -0000 1.8
> +++ usr.sbin/sysupgrade/sysupgrade.8 22 Aug 2019 08:02:25 -0000
> @@ -67,11 +67,11 @@ In case of release
>  .Nm
>  downloads the next release.
>  .It Fl s
> -Upgrade to a snapshot.
> +Upgrade to latest snapshot.

I'd like to leave it vague. Otherwise one might think sysupgrade does
some magic to find out what the latest snapshot is. While it does not.
It contacts the mirror that's set in /etc/installurl and downloads
whatever it finds there. If that mirror is behind one does not get the
latest snap.

>  The default is to find out if the system is running a release or a
> snapshot.
> -In case of release
> +In case of snapshot
>  .Nm
> -downloads the next release.
> +downloads the latest snapshot.


This is not a typo as such, it describes the default. It is a bit
awkward since it uses the same text for -r and -s. I think we can just
remove it from -s:

jmc?

diff --git sysupgrade.8 sysupgrade.8
index ba34190d979..b067d5fe691 100644
--- sysupgrade.8
+++ sysupgrade.8
@@ -68,10 +68,6 @@ In case of release
 downloads the next release.
 .It Fl s
 Upgrade to a snapshot.
-The default is to find out if the system is running a release or a snapshot.
-In case of release
-.Nm
-downloads the next release.
 .El
 .Sh FILES
 .Bl -tag -width "/home/_sysupgrade" -compact



>  .El
>  .Sh FILES
>  .Bl -tag -width "/home/_sysupgrade" -compact
> 
> -- 
> Regards,
>    Rashad

-- 
I'm not entirely sure you are real.

Reply via email to