> Date: Sat, 17 Aug 2019 14:50:10 +1000 > From: Jonathan Gray <[email protected]> > > On Fri, Aug 16, 2019 at 10:21:33PM +0200, Mark Kettenis wrote: > > The diff below provides a minimal implementation of some of the Linux > > ACPI iterfaces. Enough to allow us to compile the ACPI code for > > radeon(4) and amdgpu(4). With this diff the brightness keys on my HP > > laptop with: > > > > cpu0: AMD A4-4355M APU with Radeon(tm) HD Graphics, 1897.56 MHz, 15-10-01 > > ... > > radeondrm0 at pci0 dev 1 function 0 "ATI Radeon HD 7400G" rev 0x00 > > > > now work. I'd like to see some more tests, especially on laptops with > > amdgpu(4). Diff has some debug printing enabled. Feel free to share > > the dmesg output with me. > > In linux these files are only built with CONFIG_ACPI > so we should probably modify them to put that in the files themselves > > ./amd/amdgpu/Makefile:amdgpu-$(CONFIG_ACPI) += amdgpu_acpi.o > ./i915/Makefile:i915-$(CONFIG_ACPI) += intel_acpi.o > intel_opregion.o > ./radeon/Makefile:radeon-$(CONFIG_ACPI) += radeon_acpi.o
We can handle this in files.drm: file dev/pci/drm/radeon/radeon_acpi.c radeondrm & acpi > This diff doesn't build on at least arm64 and sparc64 Thanks for pointing this out. I'll make sure the final diff builds everywhere.
