Re: [Patch] Driver for Keyspan USA-19HS

[Jonathan Gray]

On Fri, Jun 07, 2019 at 11:08:24AM -0500, joshua stein wrote:
> On Mon, 03 Jun 2019 at 23:44:37 -0400, Cody Cutler wrote:
> > Hi jcs and tech, the following is a patch which implements jcs's feedback 
> > and
> > adds a man page.
> 
> Thanks Cody, I've imported your driver.
> 

/sys/dev/usb/ukspan.c:510:7: warning: variable 'cflag' is uninitialized when 
used here [-Wuninitialized]
        if ((cflag & CIGNORE) == 0) {
             ^~~~~

Index: ukspan.c
===================================================================
RCS file: /cvs/src/sys/dev/usb/ukspan.c,v
retrieving revision 1.1
diff -u -p -r1.1 ukspan.c
--- ukspan.c    7 Jun 2019 16:06:59 -0000       1.1
+++ ukspan.c    24 Jun 2019 14:25:06 -0000
@@ -507,8 +507,8 @@ ukspan_param(void *addr, int portno, str
                cmsg->rxmode = cmsg->txmode = 0;
 
        /* Set parity, data, and stop bits */
+       cflag = ti->c_cflag;
        if ((cflag & CIGNORE) == 0) {
-               cflag = ti->c_cflag;
                if (cflag & PARENB)
                        lcr = (cflag & PARODD) ? UKSPAN_PARITY_ODD :
                            UKSPAN_PARITY_EVEN;