Sun, Jun 09, 2019 at 02:14:57PM -0300, Martin Pieuchot wrote:
> In that case I'd like to commit the tweaked version of your diff
> below. Are you ok with it?
Yes. Though, I'd split out the following chunk
> Index: net/if_bridge.c
> ===================================================================
> RCS file: /cvs/src/sys/net/if_bridge.c,v
> retrieving revision 1.333
> diff -u -p -r1.333 if_bridge.c
> --- net/if_bridge.c 13 May 2019 18:14:05 -0000 1.333
> +++ net/if_bridge.c 9 Jun 2019 17:12:22 -0000
> @@ -363,7 +361,10 @@ bridge_ioctl(struct ifnet *ifp, u_long c
> break;
> }
> if (ifs->if_bridgeidx != 0) {
> - error = EBUSY;
> + if (ifs->if_bridgeidx == ifp->if_index)
> + error = EEXIST;
> + else
> + error = EBUSY;
> break;
> }
> SMR_SLIST_FOREACH_LOCKED(bif, &sc->sc_spanlist, bif_next) {
into its own commit: it unifies error codes, not IFT_ETHER checks.
Might ease the work of people who'll be studying commits and their reasons;
but I am not familiar enough with OpenBSD's general practices on such
questions and may be there are reasons not to do so.
Thanks a lot!
--
rea
