On Wed, May 08, 2019 at 02:54:50PM -0400, Stefan Sperling wrote: > > Add two sanity checks to iwm's firmware notification interrupt handler: > > 1) Clamp the firmware-provided index into the rx ring to the size of the ring. > Linux started doing this, too, to work around HW bugs in the 9000 series.
Right, this matches Linux commit 5eae443eb5e2b3777582ea37c6a002171ec134d5 > 2) Don't call iwm_cmd_done() if the firmware response in the Rx buffer > is not recognized. We should just skip such buffers, not act on them. > > Not tested on hardware yet; these changes evidenty shouldn't break anything. Tested: iwm0 at pci3 dev 0 function 0 "Intel Dual Band Wireless AC 3165" rev 0x81, msi iwm0: hw rev 0x210, fw ver 16.242414.0, address 08:d4:0c:xx:xx:xx > ok? ok kevlo@