On Mon, Oct 22, 2018 at 10:10:58AM +0200, Martijn van Duren wrote:
> RFC2849 states that ldif output should be prepended with a "version: 1".
> This diff adds the missing version line.
>
> OK?
>
> martijn@
>
> Index: ldapclient.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/ldap/ldapclient.c,v
> retrieving revision 1.3
> diff -u -p -r1.3 ldapclient.c
> --- ldapclient.c 3 Jul 2018 10:10:09 -0000 1.3
> +++ ldapclient.c 22 Oct 2018 08:08:21 -0000
> @@ -301,6 +301,8 @@ ldapc_search(struct ldapc *ldap, struct
> char **outvalues;
> int ret, i, code, fail = 0;
>
> + if (ldap->ldap_flags & F_LDIF)
> + printf("version: 1\n");
> do {
> if (aldap_search(ldap->ldap_al, ls->ls_basedn, ls->ls_scope,
> ls->ls_filter, ls->ls_attr, 0, ls->ls_sizelimit,
>
OK claudio@
I would add an extra newline before the "do {" to increase readability.
--
:wq Claudio
