On Tue, Jul 24, 2018 at 04:18:38PM +0200, Sebastian Benoit wrote:
> phessler@ noticed that we dont document which redistribute settings
> cause the priority filter to be enabled/disabled.
> 
> Add this text:
> 
>              The use of redistribute prefix and redistribute rtlabel can in
>              some situations result in higher cpu usage because ospfd(8)
>            needs to process more route updates.
> 
> ok?
> 

looking at if we can shorten this in any way. how about

        The use of
        .Ic redistribute Ar prefix Ns | Ns Ar rtlabel
        can in some ...

that sacrifices readability a little though. up to you.

also "in some situations" is not really needed, since you qualified it
with "can"

also i'd uppercase "CPU"

so i'd tweak it to:

        The use of
        .Ic redistribute Ar prefix Ns | Ns Ar rtlabel
        can result in higher CPU usage, since
        .Xr ospfd 8
        will need to process more route updates.

jmc

> (benno_ospfd.conf.5.diff)
> 
> diff --git usr.sbin/ospfd/ospfd.conf.5 usr.sbin/ospfd/ospfd.conf.5
> index 1928b621db0..4517c8af203 100644
> --- usr.sbin/ospfd/ospfd.conf.5
> +++ usr.sbin/ospfd/ospfd.conf.5
> @@ -185,6 +185,15 @@ Setting more than one option needs curly brackets:
>  redistribute static set { metric 300 type 2 }
>  .Ed
>  .Pp
> +The use of
> +.Ic redistribute Ar prefix
> +and
> +.Ic redistribute rtlabel
> +can in some situations result in higher cpu usage because
> +.Xr ospfd 8
> +needs to process more route updates.
> +.Ed
> +.Pp
>  .It Xo
>  .Ic rfc1583compat
>  .Pq Ic yes Ns | Ns Ic no
> 

Reply via email to