On Mon, Jul 09, 2018 at 10:31:15AM +0200, Remi Locherer wrote: > later on it is set with: > log_setverbose(ospfd_conf->opts & OSPFD_OPT_VERBOSE); > > OK?
Shouldn't we instead remove the log_setverbose(1) above the getopt call? I think the idea is that we want to be able to print debug messages between the early log_init() and the later one. In general that will allow debugging in parse_config() if -v is used. > > Index: ospf6d.c > =================================================================== > RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.c,v > retrieving revision 1.35 > diff -u -p -r1.35 ospf6d.c > --- ospf6d.c 5 Nov 2017 16:56:02 -0000 1.35 > +++ ospf6d.c 8 Jul 2018 12:59:38 -0000 > @@ -149,7 +149,6 @@ main(int argc, char *argv[]) > if (opts & OSPFD_OPT_VERBOSE) > opts |= OSPFD_OPT_VERBOSE2; > opts |= OSPFD_OPT_VERBOSE; > - log_setverbose(1); > break; > default: > usage(); > > > -- :wq Claudio
