On Sun, Jul 08 2018, Matthieu Herrb <[email protected]> wrote:
> Hi,
>
> prompted by a question by weerd@ who wanted to be able to rotate the
> screen of his gpd win *before* the Xenodm greeter is displayed, I came
> up with this (simple) patch that sources the Xsetup_0 script before
> initializing the greeter widget.
>
> I can't think of any down sides of doing this, and it may even help
> with some further pledges or privilege separation for the greeter.
>
> ok ?
fwiw no regression in my simple setup (xsession that starts both
one-shot and long-running X programs).
> Index: greeter/greet.c
> ===================================================================
> RCS file: /cvs/OpenBSD/xenocara/app/xenodm/greeter/greet.c,v
> retrieving revision 1.5
> diff -u -r1.5 greet.c
> --- greeter/greet.c 6 May 2018 15:25:27 -0000 1.5
> +++ greeter/greet.c 30 Jun 2018 08:51:44 -0000
> @@ -301,13 +301,13 @@
> Arg arglist[2];
> Display *dpy;
>
> - dpy = InitGreet (d);
> /*
> * Run the setup script - note this usually will not work when
> * the server is grabbed, so we don't even bother trying.
> */
> if (!d->grabServer)
> SetupDisplay (d);
> + dpy = InitGreet (d);
> if (!dpy) {
> LogError ("Cannot reopen display %s for greet window\n", d->name);
> exit (RESERVER_DISPLAY);
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
