On Mon, Dec 11, 2017 at 01:41:50PM +0100, Martijn van Duren wrote: > Both options have their risks and aren't particularly pretty. > Maybe the auto-generation option is a bit safer, because a comment is > harder to overlook than a separate file. > > Two minor nits on your patch (modified patch below): > 1) You forgot to change ex/ex.awk to enum > 2) I don't like the trailing comma after the last element (personal > quirk, feel free to ignore).
As I mentioned, I deliberately made it so that the generated files match the files in the tree. :) I was gravitating towards omitting the patch to the awk file, but your version is fine with me: I agree that both headers should be treated the same way. I'd say wait a day or two to give people a chance to object, then go ahead with your patch and my ok.
