On Tue, 28 Nov 2017 08:08:24 +0000, Otto Moerbeek wrote: > On Sun, Nov 26, 2017 at 07:25:46PM +0000, kshe wrote: > > Hi, > > > > The diff below encompasses three unrelated minor changes. > > > > 1. Merge the not_equal(), not_less() and not_greater() functions into > > their caller; these functions cannot be called from the jump table, so > > it is confusing to define them as if they could. > > > > 2. Make warnings consistent by using warnx(3) everywhere. > > > > 3. Add a missing parenthesis in a comment. > > I committed this; but you diff does not apply, I had to fix it. Looks > like you edited line numbers manually or something like that.
This is actually the opposite: I extracted this diff from a larger one without editing line numbers, as I thought they did not matter much for contextual diffs. Apparently, this works well as long as two unrelated changes are more than six lines apart; otherwise, well, they appear in the same window and things get more complicated. By the way, while fixing my broken patch, it seems that you forgot to remove the newline at the end of the argument to warnx() in not_compare(). Regards, kshe
