On Sat, Nov 25 2017, Brent Cook <[email protected]> wrote: > Thanks guys. This will make enabling this on the odder platforms in > portable easier.
NB: if we want to able to mix app_tminterval() for real and user time, the static storage used for "start" should be different. This is not the case for the Windows implementation, which *seems* to support only user time: https://github.com/libressl-portable/portable/blob/master/apps/openssl/apps_win.c Another approach, which would require more changes, would be to just provide two seperate functions, possibly named app_timer_real() and app_timer_user(). The Windows version of app_timer_real() could start as a simple copy of app_timer_user(), marked with XXX... > On Fri, Nov 24, 2017 at 7:03 AM, Scott Cheloha <[email protected]> > wrote: > >> > On Nov 24, 2017, at 6:58 AM, Jeremie Courreges-Anglas <[email protected]> >> wrote: >> > >> > On Wed, Nov 22 2017, Scott Cheloha <[email protected]> wrote: >> >> Whoops, ignore that last patch, it lacked the >> >> static changes in apps_posix.c >> > >> > This looks good to me. I'm tempted to commit the apps_posix.c part >> > first: it seems to me that app_tminterval() could be reused in s_time.c, >> > leading to simpler code instead of inlining clock_gettime calls. >> >> I intend to refactor that module next. One thing I was going to >> do was abstract away the timer interface, so that works. >> >> -- >> Scott Cheloha >> >> -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
