Hello,

your change looks good to me as-is.

Though the patch itself drags my attention to line here in pf_test():
</snip>
> @@ -7072,7 +7083,8 @@ done:
>  
>  #ifdef INET6
>       /* if reassembled packet passed, create new fragments */
> -     if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD) {
> +     if (pf_status.reass && action == PF_PASS && pd.m && fwdir == PF_FWD &&
> +         pd.af == AF_INET6) {
>               struct m_tag    *mtag;
>  
>               if ((mtag = m_tag_find(pd.m, PACKET_TAG_PF_REASSEMBLED, NULL)))

    I wonder whether the test 'fwdir == PF_FWD' is correct. I need to think more
    about what happens to reassembled packets in PF_OUT direction. I suggest to
    deal with it in separate thread.

I'm OK with your patch as-is.

thanks and
regards
sasha

Reply via email to