usage() never returns, all functions are to be used within this unit
only.

Since changes are conflicting, I'll wait for this diff first, but I'd
like to remove the void casts for fprintf and use getprogname(3) over
__progname as well.

Feedback? Comments?

Index: kill.c
===================================================================
RCS file: /cvs/src/bin/kill/kill.c,v
retrieving revision 1.14
diff -u -p -r1.14 kill.c
--- kill.c      29 Mar 2017 22:40:15 -0000      1.14
+++ kill.c      24 Jul 2017 21:03:03 -0000
@@ -42,10 +42,10 @@
 
 extern char *__progname;
 
-void nosig(char *);
-void printsignals(FILE *);
-int signame_to_signum(char *);
-void usage(void);
+static void __dead     nosig(char *);
+static void            printsignals(FILE *);
+static int             signame_to_signum(char *);
+static void __dead     usage(void);
 
 int
 main(int argc, char *argv[])
@@ -148,7 +148,7 @@ signame_to_signum(char *sig)
        return (-1);
 }
 
-void
+static void __dead
 nosig(char *name)
 {
 
@@ -171,7 +171,7 @@ printsignals(FILE *fp)
        }
 }
 
-void
+static void __dead
 usage(void)
 {
        (void)fprintf(stderr, "usage: %s [-s signal_name] pid ...\n",

Reply via email to