On Sun, Jul 02, 2017 at 02:56:06PM +0200, Stefan Sperling wrote: > On Sat, Jul 01, 2017 at 05:53:54PM -0400, Rob Pierce wrote: > > never.never say always.always. > > > > Rename one of the "always" variables to "body" for improved readability. > > > > No functional change. > > > > >From ifstated.conf(5): > > > > "Each state consistes of an init block and a body. The init block is used > > to initialize the state and is executed each time the state is entered. > > The body of a state is only executed when that state is the current state > > and an event occurs." > > > > Rob > > I agree with this change. > > Could you make the same change for struct ifsd_config in a follow-up diff?
Will do. I have made the change for struct ifsd_config locally, but wanted to get this first change committed prior to sending the next diff to make it less confusing. It is still somewhat awkward because there is both an init state (i.e. init-state) as well as an init block within each state. I have renamed the second (struct ifsd_config) instance of "always" to "initstate". Stay tuned. Rob