Rob Pierce([email protected]) on 2017.06.13 19:12:18 -0400:
> On Tue, Jun 13, 2017 at 08:44:46AM +0200, Sebastian Benoit wrote:
> > Rob Pierce([email protected]) on 2017.06.11 18:04:31 -0400:
> > > This minimizes differences with the latest log.c.
> > > 
> > > I was not sure how to handle verbosity, as the current implementation is
> > > verbose by default in debug mode. The diff below requires actually
> > > requesting (double) verbosity on the command line in order to retain the
> > > same behaviour (in debug mode).
> > 
> > Thanks.
> > 
> > can you redo this with the log.c from bgpd/ospfd/... ?
> > The difference is exactly in the handling of verbose, and that way we dont
> > change the -v semantics right now.
> > 
> > I havent unified the verbose handling yet, but if you diff them you'll see
> > its only a small difference now. My plan is to narrow all the log.c users
> > down to this small difference and then fix that in all of them in one go.
> > 
> > Also please add a log.h with the declarations just like in bgpd/ospfd/...
> > 
> > /Benno
> 
> Ah yes, thank you for the pointer. How is this?

commited, thanks!

Reply via email to