On Thu, Jun 08, 2017 at 10:33:07PM +1000, Jonathan Gray wrote:
> On Fri, May 19, 2017 at 12:35:44AM -0500, Matthew Martin wrote:
> > While making the last patch, I noticed ikectl uses getpass. Use
> > readpassphrase instead and explicit_bzero the buffers.
> >
> > - Matthew Martin
>
> What is the goal here? It can't be to use a different buffer size as
> the same size as getpass is used.
getpass(3) states
This function is obsolete. Consider using readpassphrase(3).
which I took to mean replace the function when you come across it.
Perhaps I've misinterpreted things.
> getpass is implemented in terms of readpassphrase. Looking at the
> implementation the flags argument should be RPP_ECHO_OFF (0) rather
> than just 0.
I believe you're correct.
- Matthew Martin
