On Sat, Jun 10, 2017 at 09:23:45AM +0200, Stefan Sperling wrote: > On Fri, Jun 09, 2017 at 06:33:46PM +0200, Stefan Sperling wrote: > > This diff changes the way dynamic addresses are configured in sppp(4). > > I was asked in private whether we could avoid a flag day which makes > it inconvenient to upgrade remote boxes only reachable over pppoe(4). > > I see no harm in keeping the old magic working for now. > The new mechanism still works, and the goal of allowing more than one pppoe > instance per routing table does not conflict with temporary backwards compat. > So we would release 6.2 with support for both ways, and remove the old way > in 6.3 or later. This gives people some time for the transition. > > This diff also contains doc updates requested by jmc@. >
thanks. the ifconfig.8 bits look good, but i think you should also change the examples given in pppoe(4) to show the updated syntax, to prepare folks. actually i think it would be better to discuss the deprecated stuff in pppoe(4), rather than adding it to ifconfig(8). jmc > Index: sbin/ifconfig/ifconfig.8 > =================================================================== > RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v > retrieving revision 1.282 > diff -u -p -r1.282 ifconfig.8 > --- sbin/ifconfig/ifconfig.8 12 May 2017 15:11:02 -0000 1.282 > +++ sbin/ifconfig/ifconfig.8 10 Jun 2017 07:08:01 -0000 > @@ -1393,6 +1393,8 @@ Clear a previously set service name. > .Op Cm authkey Ar key > .Op Cm authname Ar name > .Op Cm authproto Ar proto > +.Op Oo Fl Oc Ns Cm dynaddr > +.Op Oo Fl Oc Ns Cm dyndest > .Op Oo Fl Oc Ns Cm peerflag Ar flag > .Op Cm peerkey Ar key > .Op Cm peername Ar name > @@ -1419,6 +1421,21 @@ The protocol name can be either > or > .Ql none . > In the latter case, authentication will be turned off. > +.It Cm dynaddr > +The local address will be changed to an address suggested by the peer. > +A deprecated way of achieving the same effect is setting the local address > +to 0.0.0.0. > +.It Cm -dynaddr > +Disable dynamic updates of the local address. > +This is the default. > +.It Cm dyndest > +The destination address will be changed to an address suggested by the peer. > +A deprecated way of achieving the same effect is setting the destination > +address to 0.0.0.1 (multiple SPPP interfaces configured with this destination > +address cannot share a routing table). > +.It Cm -dyndest > +Disable dynamic updates of the destination address. > +This is the default. > .It Cm peerflag Ar flag > Set a specified PPP flag for the remote authenticator. > The flag name can be either
