On Fri, Jun 09, 2017 at 09:28:29PM +0000, [email protected] wrote:
> Hello!
>
> Here is a patch with a pledge bugfix in netcat and some minor style
> improvements.
>
> An example of how to trigger the bug:
>
> $ nc -Ptest -v -c blog.tintagel.pl 443
> nc: pledge: Operation not permitted
>
> credits to
> * awolk@ for drawing attention to netcat.
> * Juuso Lapinlampi for suggesting to alphabetically order the #includes.
> * rajak for pointing out the missing space in the error message.
> * brynet for pledge style improvements.
>
>
OK awolk@ for the updated diff (I'm attaching it inline).
Would like a second OK on this.
Testing results, pre diff:
$ nc -H 123 -T noverify -c localhost 22
nc: -H and -T noverify may not be usedtogether
$ nc -Ptest -v -c blog.tintagel.pl 443
nc: pledge: Operation not permitted
$
Post diff:
$ ./nc -H 123 -T noverify -c localhost 22
nc: -H and -T noverify may not be used together
$ ./nc -Ptest -v -c blog.tintagel.pl 443
Connection to blog.tintagel.pl 443 port [tcp/https] succeeded!
TLS handshake negotiated TLSv1.2/ECDHE-RSA-AES256-GCM-SHA384 with host
blog.tintagel.pl
Peer name: blog.tintagel.pl
Subject: /CN=tintagel.pl
Issuer: /C=US/O=Let's Encrypt/CN=Let's Encrypt Authority X3
Valid From: Thu Apr 27 04:01:00 2017
Valid Until: Wed Jul 26 04:01:00 2017
Cert Hash:
SHA256:1746b1d2ecdf8ad1fb7e06a6c97154b2c1a87eee65f5654824d0a0dc0af4ba98
OCSP URL: http://ocsp.int-x3.letsencrypt.org/
^C
$
Test on amd64 -current
Regards,
Adam
