On Wed, Jun 07, 2017 at 05:58:42PM +1000, David Gwynne wrote: > On Wed, Jun 07, 2017 at 07:32:18AM +0100, Jason McIntyre wrote: > > On Wed, Jun 07, 2017 at 02:51:42PM +1000, David Gwynne wrote: > > > > > > > > you are breaking the format of this page if you start to move specific > > > > subsytems into the main body. > > > > > > > > that makes things less clear. for example, can i use the parent-device > > > > stuff on any type of interface or just vlan? if it's vlan related, how > > > > can i tell that? > > > > > > the "parent" ioctls are generic, but it is only implemented in vlan > > > currently. i have a plan to replace "carpdev", "syncdev", and "pppoedev" > > > with it, but id like to finish the vlan stuff before going further. > > > > > > > so it sounds like it should be in vlan for now. > > cool. > > > > > > vnetid is used by both vlan and vxlan at the moment. i have a diff to add > > > support for it to gre, while adding egre (ethernet over gre) and nvgre > > > interfaces that also support a network identifier. > > > > > > > > > > > the text reads fine, but i'd rather you tried to integrate it into the > > > > vlan section. if there are errors in there let's remove them. > > > > > > > > but if it's the case that none of this stuff is specific to vlan, then i > > > > guess it makes sense to do it your way (but then you'd have to take care > > > > when documenting stuff like parent-device to say in what situations it > > > > makes sense). > > > > > > im happy to take direction here. i could also move things like the > > > ethernet options (arp, -arp, instance, wol, -wol) into their own section. > > > > > > > well, that would be a separate diff. > > > > > how would you say that vnetid is supported by both vlan and some tunnel > > > interfaces? would you put it in the tunnel section, the vlan section, or > > > both, or a new section? > > > > > > dlg > > > > > > > just like it is just now. > > > > i know that the way that ifconfig(8) is split up is not perfect. that is > > really just a reflection of how complex a tool ifconfig is. by complex i > > mean it can do a lot of different stuff. the format of the page as-is > > now just kind of happened. i'm not saying we can't (or shouldn;t) change > > it, just that if we do, we'd want to try and keep it consistent. > > > > why not just add your one option to the vlan section, which is what it's > > relevant to, for now. if in the future you make it work in other areas, > > we can see whether it warrants a shuffle. > > well, vnetid and parent replace the vlan and vlandev parameters. > > how about this as a start? > > as an aside, should i fix vlan.4 so it uses capitals on the 802.1 > things consistently? capitals are preferred, right? >
Be careful, AFAIK the capitalisation of IEEE standards does matter. You're right 802.1Q is the correct spelling but not for 802.1ad (where the lowercase version is the offical standard). IIRC the status of the standard is what causes the letters to become uppercase. -- :wq Claudio
