On Mon, May 08, 2017 at 03:54:38PM +0200, Mark Kettenis wrote: > > Date: Mon, 8 May 2017 15:36:11 +0200 > > From: Stefan Sperling <[email protected]> > > > > In iwm_send_cmd(), look at the generation counter instead of the STOPPED > > flag > > to determine whether the interface was reset while we were sleeping. The > > flag > > will be set if the interface is still down when the task wakes up, but the > > interface could already be up again in which case the flag will be cleared. > > A stale task which sends an outdated command could confuse the firmware. > > Makes sense. The comment isn't really accurate now though...
Yes, the comments could be better. I'll eventually do another pass over the driver just fixing stylistic issues such as this (probably during d2k17).
