On Sun, Mar 26, 2017 at 06:31:41PM +1100, Jonathan Gray wrote:
> On Sun, Mar 26, 2017 at 09:14:26AM +0200, Anton Lindqvist wrote:
> > Hi,
> > An assignment introduced in r1.219 looks redundant.
>
> child is assigned every iteration of the loop this diff looks wrong to me.
It's being assigned in the if statement.
-Otto
>
> >
> > Index: dsdt.c
> > ===================================================================
> > RCS file: /cvs/src/sys/dev/acpi/dsdt.c,v
> > retrieving revision 1.231
> > diff -u -p -r1.231 dsdt.c
> > --- dsdt.c 16 Feb 2017 18:02:22 -0000 1.231
> > +++ dsdt.c 25 Mar 2017 21:16:04 -0000
> > @@ -1261,7 +1261,6 @@ aml_find_node(struct aml_node *node, con
> > const char *nn;
> >
> > SIMPLEQ_FOREACH(child, &node->son, sib) {
> > - nn = child->name;
> > if ((nn = child->name) != NULL) {
> > if (*nn == AMLOP_ROOTCHAR) nn++;
> > while (*nn == AMLOP_PARENTPREFIX) nn++;
> >
