On Sat, 18 Mar 2017, Mark Kettenis wrote:
> > Date: Sat, 18 Mar 2017 17:20:21 +0100
> > From: Patrick Wildt <patr...@blueri.se>
> > 
> > On Sat, Mar 18, 2017 at 03:47:18PM +0100, Mark Kettenis wrote:
> > > Just like we did on other architectures.
> > > 
> > > ok?
> > 
> > guenther@ had the same diff (but he also removed the movn x1), which
> > looked good to me as well.  Basically still ok patrick@. ;)

iirc you hadn't had a chance to actually run it and I was waiting for 
someone who actually has the hardware to confirm I didn't miss something 
dumb...

So obviously ok guenther@


> Hmm, the arm version still has the equivalent movn r1.  I'll let
> guenther@ deal with that.

Ah, but it's necessary there...for correct error return from lseek(). 
64bit archs never need the second return register...and I've already 
removed it from the equivalent of cerror on all the other 64bit archs.


Philip

Reply via email to