On 01/25/17 01:32, Martin Pieuchot wrote: > I just enabled the NET_LOCK() again and I'm looking for test reports. > Please go build a kernel from sources or wait for the next snapshot, > run it and report back. > > If you're looking for some small coding tasks related to the NET_LOCK() > just do: > > # sysctl kern.splassert=2 > # sysctl kern.pool_debug=2 > > Then watch for the traces on your console. > > You'll see something like: > > Starting stack trace... > yield(0,1,d09dac52,f5549dbc,d94e9378) at yield+0xa4 > yield(d0bc8f40,1,f5549e18,80,14) at yield+0xa4 > pool_get(d0bc8f40,1,f5549ec8,d03ecbfb,d97815f4) at pool_get+0x1ba > m_get(1,3,f5549ec0,d03a9362,d0bc22e0) at m_get+0x30 > doaccept(d977e6c4,3,cf7ee4f8,cf7ee4ec,2000) at doaccept+0x193 > sys_accept(d977e6c4,f5549f5c,f5549f7c,0,f5549fa8) at sys_accept+0x37 > syscall() at syscall+0x250 > > This means accept(2) is doing a memory allocation that can sleep, here > with m_get(9), while holding the NET_LOCK(). Even if these should be > ok, it is easy to avoid them. In the case of doaccept() a mbuf could > be allocated beforehand or simply use the stack for that.
I updated my firewall w/ amd64 -current (GENERIC.MP) #154 and got quite a lot of data. The full serial console[1] is ~130k. Here's a bit of a summary: >grep -e 'syscall ' Log.tarpit.NET_LOCK.ddb.01 | sort|uniq -c|sort -nr 94 --- syscall (number 105) --- 86 --- syscall (number 54) --- 33 --- syscall (number 97) --- 24 --- syscall (number 118) --- 3 --- syscall (number 202) --- [1]<http://arp.thrush.com/obsd/Log.tarpit.NET_LOCK.ddb.01> ##################################################################### OpenBSD 6.0-current (GENERIC.MP) #154: Wed Jan 25 19:50:16 MST 2017 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP real mem = 4273856512 (4075MB) avail mem = 4139667456 (3947MB) mpath0 at root scsibus0 at mpath0: 256 targets mainbus0 at root bios0 at mainbus0: SMBIOS rev. 2.7 @ 0x7fbf0420 (7 entries) bios0: vendor coreboot version "ADI_RCCVE-01.00.00.08-nodebug" date 01/22/2016 bios0: ADI Engineering RCC-VE acpi0 at bios0: rev 2 acpi0: sleep states S0 S4 S5 acpi0: tables DSDT FACP SPCR HPET APIC MCFG SSDT acpi0: wakeup devices EHC1(S4) acpitimer0 at acpi0: 3579545 Hz, 24 bits acpihpet0 at acpi0: 14318179 Hz acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat cpu0 at mainbus0: apid 0 (boot processor) cpu0: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1750.32 MHz cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT cpu0: 1MB 64b/line 16-way L2 cache cpu0: TSC frequency 1750324380 Hz cpu0: smt 0, core 0, package 0 mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges cpu0: apic clock running at 83MHz cpu0: mwait min=64, max=64, C-substates=0.2.0.0.0.0.3, IBE cpu1 at mainbus0: apid 2 (application processor) cpu1: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1749.99 MHz cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT cpu1: 1MB 64b/line 16-way L2 cache cpu1: smt 0, core 1, package 0 ioapic0 at mainbus0: apid 2 pa 0xfec00000, version 20, 24 pins acpimcfg0 at acpi0 addr 0xe0000000, bus 0-255 acpiprt0 at acpi0: bus 1 (RP01) acpiprt1 at acpi0: bus 2 (RP02) acpiprt2 at acpi0: bus 3 (RP03) acpiprt3 at acpi0: bus 4 (RP04) acpiprt4 at acpi0: bus 0 (PCI0) acpicpu0 at acpi0: C1(@1 halt!), PSS acpicpu1 at acpi0: C1(@1 halt!), PSS cpu0: Enhanced SpeedStep 1750 MHz: speeds: 2100, 1800, 1600, 1400 MHz pci0 at mainbus0 bus 0 pchb0 at pci0 dev 0 function 0 vendor "Intel", unknown product 0x1f0e rev 0x02 ppb0 at pci0 dev 1 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi pci1 at ppb0 bus 1 ppb1 at pci0 dev 2 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi pci2 at ppb1 bus 2 ppb2 at pci0 dev 3 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi pci3 at ppb2 bus 3 ppb3 at pci0 dev 4 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi pci4 at ppb3 bus 4 vendor "Intel", unknown product 0x1f18 (class processor subclass Co-processor, rev 0x02) at pci0 dev 11 function 0 not configured pchb1 at pci0 dev 14 function 0 "Intel Atom C2000 RAS" rev 0x02 "Intel Atom C2000 RCEC" rev 0x02 at pci0 dev 15 function 0 not configured "Intel Atom C2000 SMBus" rev 0x02 at pci0 dev 19 function 0 not configured em0 at pci0 dev 20 function 0 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:0a:73:bd em1 at pci0 dev 20 function 1 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:0a:73:be em2 at pci0 dev 20 function 2 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:0a:73:bf em3 at pci0 dev 20 function 3 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:0a:73:c0 ehci0 at pci0 dev 22 function 0 "Intel Atom C2000 USB" rev 0x02: apic 2 int 22 usb0 at ehci0: USB revision 2.0 uhub0 at usb0 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00 addr 1 ahci0 at pci0 dev 23 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3 scsibus1 at ahci0: 32 targets ahci1 at pci0 dev 24 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3 scsibus2 at ahci1: 32 targets pcib0 at pci0 dev 31 function 0 "Intel Atom C2000 PCU" rev 0x02 ichiic0 at pci0 dev 31 function 3 "Intel Atom C2000 PCU SMBus" rev 0x02: apic 2 int 22 iic0 at ichiic0 iic0: addr 0x2e 00=41 words 00=4141 01=0000 02=0000 03=0000 04=0000 05=0000 06=0000 07=0000 spdmem0 at iic0 addr 0x50: 4GB DDR3 SDRAM PC3-12800 with thermal sensor isa0 at pcib0 isadma0 at isa0 com0 at isa0 port 0x3f8/8 irq 4: ns16550a, 16 byte fifo com1 at isa0 port 0x2f8/8 irq 3: ns16550a, 16 byte fifo com1: console pcppi0 at isa0 port 0x61 spkr0 at pcppi0 vmm0 at mainbus0: VMX/EPT uhub1 at uhub0 port 1 configuration 1 interface 0 "Intel product 0x07db" rev 2.00/0.02 addr 2 umass0 at uhub1 port 4 configuration 1 interface 0 "Generic Ultra Fast Media" rev 2.00/1.98 addr 3 umass0: using SCSI over Bulk-Only scsibus3 at umass0: 2 targets, initiator 0 sd0 at scsibus3 targ 1 lun 0: <Generic, Ultra HS-COMBO, 1.98> SCSI0 0/direct removable serial.04242240000000225001 sd0: 7456MB, 512 bytes/sector, 15269888 sectors vscsi0 at root scsibus4 at vscsi0: 256 targets softraid0 at root scsibus5 at softraid0: 256 targets root on sd0a (0ca75d8a3e6a778d.a) swap on sd0b dump on sd0b
