On Mon, Nov 07, 2016 at 10:16:14AM +0100, Martin Pieuchot wrote:
> @@ -366,18 +362,23 @@ redo:
>
> if (error) {
> /* if an error occurred, free the file descriptor */
> + splx(s);
> + m_freem(nam);
> fdplock(fdp);
> fdremove(fdp, tmpfd);
> closef(fp, p);
> fdpunlock(fdp);
> + goto out;
> } else {
You don't need an else after a goto.
> (*fp->f_ops->fo_ioctl)(fp, FIONBIO, (caddr_t)&nflag, p);
> FILE_SET_MATURE(fp, p);
> *retval = tmpfd;
> + m_freem(nam);
Just move this code one tab to the left.
> }
> - m_freem(nam);
> +
> bad:
> splx(s);
> +out:
> FRELE(headfp, p);
> return (error);
> }
OK bluhm@
