On Fri, Jun 24, 2016 at 11:22:06AM +0200, Joris Vink wrote: > On Fri, Jun 24, 2016 at 01:58:20PM +0800, Michael W. Bombardieri wrote:
> > If people are interested in opencvs diffs again, sharing a > > rcsnum_free()->free() > > clean-up item. Note that rcs(1) also has a version of rcsnum_free() which > > does more > > than simply call free(). > > This is good. Eventually the rcs(1) rcsnum code should get the same > simplification as opencvs got regarding how it deals with rn_id as well. Looks good to me, with a caveat though: there is a missing include on stdlib.h in getlog.c, which breaks compilation. With the missing include this is OK fcambus@ if anyone wants to commit.
