acpiec on acer aspire S7 with CURRENT

[Ilya Kaliman]

Hi tech,

while trying the latest snapshot I've noticed that the following
warning is printed to a console several times a second (this does not
happen in 6.0):

acpi0: WARNING EC not initialized

The investigation shows that the acpiec initialization fails in
acpiec.c line 484:

if (size != 2 || *buf != RES_TYPE_ENDTAG)

On my system at this point the size value is 22 and the *buf is 0x47
(RES_TYPE_IOPORT).

I am not sure what the proper fix is, but removing the whole _CRS
ENDTAG check solves the problem (see attached patch).

Thanks,
Ilya

===================================================================
RCS file: /cvs/src/sys/dev/acpi/acpiec.c,v
retrieving revision 1.54
diff -u -p -r1.54 acpiec.c
--- acpiec.c    23 Aug 2016 18:26:21 -0000      1.54
+++ acpiec.c    10 Oct 2016 21:55:59 -0000
@@ -477,15 +477,6 @@ acpiec_getcrs(struct acpiec_softc *sc, s
                aml_freevalue(&res);
                return (1);
        }
-
-       buf += ret;
-       size -= ret;
-
-       if (size != 2 || *buf != RES_TYPE_ENDTAG) {
-               dnprintf(10, "%s: no _CRS end tag\n", DEVNAME(sc));
-               aml_freevalue(&res);
-               return (1);
-       }
        aml_freevalue(&res);