Hi,
Although this doesn't seem to cause any issue at the moment, using an
enum type in a __packed struct should be avoided:
Index: sys/dev/pci/if_iwmreg.h
===================================================================
RCS file: /cvs/src/sys/dev/pci/if_iwmreg.h,v
retrieving revision 1.14
diff -u -r1.14 if_iwmreg.h
--- sys/dev/pci/if_iwmreg.h 20 Jul 2016 18:24:38 -0000 1.14
+++ sys/dev/pci/if_iwmreg.h 31 Aug 2016 18:53:25 -0000
@@ -3225,14 +3225,14 @@
/**
* Smart Fifo configuration command.
- * @state: smart fifo state, types listed in iwm_sf_sate.
+ * @state: smart fifo state, types listed in enum %iwm_sf_state.
* @watermark: Minimum allowed availabe free space in RXF for transient state.
* @long_delay_timeouts: aging and idle timer values for each scenario
* in long delay state.
* @full_on_timeouts: timer values for each scenario in full on state.
*/
struct iwm_sf_cfg_cmd {
- enum iwm_sf_state state;
+ uint32_t state;
uint32_t watermark[IWM_SF_TRANSIENT_STATES_NUMBER];
uint32_t
long_delay_timeouts[IWM_SF_NUM_SCENARIO][IWM_SF_NUM_TIMEOUT_TYPES];
uint32_t
full_on_timeouts[IWM_SF_NUM_SCENARIO][IWM_SF_NUM_TIMEOUT_TYPES];