Hi Nic, Nicholas Marriott wrote on Fri, Apr 29, 2016 at 10:08:18AM +0100:
> If this was just guaranteed nonprintable characters, there would be no > issue. But the problem is that some platforms are missing genuine UTF-8 > characters and since many terminals do not use wcwidth(), it means that > users who used older versions of tmux had working characters that now do > not work even though the terminal is happy to show them. > > I think if nonprintable characters show up, it will be because a user > printed garbage and they will know they printed garbage and not expect > sensible output. > > However I think you are right and there is no reason for this to be in > OpenBSD, I'll move it into portable tmux only. Since it is only a couple > of lines it is not a big issue. After your explanations, i agree that's the best course of action. Your commit looks good. Thanks! > I don't think it is tmux's role to protect the terminal and there > is no way it can do it. Understood. As you said, running stuff outside tmux(1) has no such protection, either. That's why programs like ls(1) and ps(1) already sanitize their output. And when people cat(1) untrusted files to the terminal, they get what they deserve. Yours, Ingo
