On Tue, Mar 22, 2016 at 01:07:29PM +0100, Alexander Bluhm wrote: > On Tue, Mar 22, 2016 at 07:20:56AM +0000, Jason McIntyre wrote: > > > -formatted message direct to > > > +formatted message directly to > > > > i think both are acceptable. i actually prefer how it is now. > > There was another "directly" in the next sentence. I have removed > that to avoid inconsistency. > > > > +.It Bq Er EMSGSIZE > > > +The socket requires that message be sent atomically, and the size > > > > messages? a message? the message? > > you need something though. > > I had copied it from send(2), both man pages should be fixed.
ok, but one more comment about the sentence above: > > bluhm > > Index: send.2 > =================================================================== > RCS file: /data/mirror/openbsd/cvs/src/lib/libc/sys/send.2,v > retrieving revision 1.31 > diff -u -p -r1.31 send.2 > --- send.2 9 Sep 2014 06:32:37 -0000 1.31 > +++ send.2 22 Mar 2016 11:52:22 -0000 > @@ -147,7 +147,7 @@ is not a socket. > .It Bq Er EFAULT > An invalid user space address was specified for a parameter. > .It Bq Er EMSGSIZE > -The socket requires that message be sent atomically, > +The socket requires that messages are sent atomically, the text was already correct. the addition you propose should use this text (and not the be->are change). jmc > and the size of the message to be sent made this impossible. > .It Bq Er EAGAIN > The socket is marked non-blocking or the > Index: sendsyslog.2 > =================================================================== > RCS file: /data/mirror/openbsd/cvs/src/lib/libc/sys/sendsyslog.2,v > retrieving revision 1.7 > diff -u -p -r1.7 sendsyslog.2 > --- sendsyslog.2 22 Mar 2016 07:13:16 -0000 1.7 > +++ sendsyslog.2 22 Mar 2016 11:57:54 -0000 > @@ -33,29 +33,36 @@ function is used to transmit a > formatted message direct to > .Xr syslogd 8 > without requiring the allocation of a socket. > -.Pp > -The > -.Fa flags > -argument of > -.Fn sendsyslog > -accepts the > -.Dv LOG_CONS > -flag. > If > .Dv LOG_CONS > -is specified, and > +is specified in the > +.Fa flags > +argument, and > .Xr syslogd 8 > -is not accepting messages, the message will be sent directly to the > -console. > +is not accepting messages, the message will be sent to the console. > This is used internally by > .Xr syslog_r 3 , > so that messages can be sent during difficult situations. > +If sending to > +.Xr syslogd 8 > +fails, dropped messages are counted. > +When > +.Xr syslogd 8 > +works again, a warning with the counter and error number is logged. > .Sh RETURN VALUES > .Rv -std > .Sh ERRORS > .Fn sendsyslog > can fail if: > .Bl -tag -width Er > +.It Bq Er EFAULT > +An invalid user space address was specified for a parameter. > +.It Bq Er EMSGSIZE > +The socket requires that messages are sent atomically, > +and the size of the message to be sent made this impossible. > +.It Bq Er ENOBUFS > +The system was unable to allocate an internal buffer. > +The operation may succeed when buffers become available. > .It Bq Er ENOTCONN > The message cannot be sent, likely because > .Xr syslogd 8 > @@ -69,3 +76,7 @@ The > .Fn sendsyslog > function call appeared in > .Ox 5.6 . > +The > +.Fa flags > +argument was added in > +.Ox 6.0 .
