On Sat, Mar 05, 2016 at 11:32:04AM -0800, Philip Guenther wrote: > On Sat, Mar 5, 2016 at 8:10 AM, Michal Mazurek <akf...@jasminek.net> wrote: > > sys/compat is gone. I don't know if PID_MAX can or should be increased, > > but I don't think the comment is now useful. > > I think we can go a bit further now and include PID_MAX to 99999 (to > keep it in 5 columns). > > ok? > > Philip Guenther > > Index: proc.h > =================================================================== > RCS file: /data/src/openbsd/src/sys/sys/proc.h,v > retrieving revision 1.214 > diff -u -p -r1.214 proc.h > --- proc.h 4 Mar 2016 14:08:55 -0000 1.214 > +++ proc.h 5 Mar 2016 19:30:27 -0000 > @@ -409,9 +409,9 @@ struct uidinfo *uid_find(uid_t); > /* > * We use process IDs <= PID_MAX; PID_MAX + 1 must also fit in a pid_t, > * as it is used to represent "no process group". > - * We set PID_MAX to (SHRT_MAX - 1) so we don't break sys/compat. > + * We set PID_MAX to 99999 to keep it in 5 columns in ps > */ > -#define PID_MAX 32766 > +#define PID_MAX 99999 > #define NO_PID (PID_MAX+1) > > #define SESS_LEADER(pr) ((pr)->ps_session->s_leader == (pr)) >
Looks good to me. Fwiw, linux_pid_t was typedefed as int, so the limitation to SHRT_MAX must have been for another compate module. natano
