On Mon, Feb 01, 2016 at 02:55:52AM +0200, Artturi Alm wrote: > On Sun, Jan 31, 2016 at 10:45:42PM +1100, Jonathan Gray wrote: > > On Sun, Jan 31, 2016 at 10:12:05AM +0200, Artturi Alm wrote: > > > On Sun, Jan 31, 2016 at 01:14:35AM +0100, Patrick Wildt wrote: > > > > Hi, > > > > > > > > one of the reasons Allwinner A20/sun7i-based boards, like the > > > > Cubieboard 2 or Banana Pi, don't boot is that the sxitimer does > > > > not work for us. We are getting no hardclock ticks and so the > > > > system can't work. > > > > > > > > There's a simple fix for that. We can just not use the sxitimer > > > > and instead use the ARM architected timer (agtimer) that is > > > > supposed to be a generic implementation for all new cores and > > > > already attaches anyway. The sxitimer attachment currently > > > > overrides the agtimer. Removing sxitimer thus allows agtimer > > > > to actually do its work. > > > > > > > > Currently sxirtc uncondtionally ties into sxitimer. To make > > > > this work, just make sxirtc map its own page instead of relying > > > > on the existence of a mapping created by sxitimer. > > > > > > > > The address/size used for the sxirtc is from a device tree > > > > source. > > > > > > > > Patrick > > > > > > > > > > Hi, > > > > > > nothing i would change about your diff, given now there's agtimer, > > > but it doesn't really seem to even try fixing rtc on A20, and leaves > > > ugly glue into sxitimer written just for A20, which imho should also > > > get cleaned up. > > > > > > -Artturi > > > > There seem to be at least two diffs here, the different rtc handling > > for a20 should be split out, store sxirtc_a20 in the softc and fix > > the test from > > if (BOARD_ID_SUN7I_A20) > > to > > if (board_id == BOARD_ID_SUN7I_A20) > > > > Yes, it was quick try during my morning coffee, i'm sorry to have wasted > your time with the previous obviously wrong diff. > > sxitimer a20 support glue cleanup diff inline. > > -Artturi
Thanks, both diffs committed. Any chance you could create another to move the sxitimer_* globals into the softc?
