On Tue 2015.11.10 at 00:40 +0100, Vadim Vygonets wrote:
> Quoth Okan Demirmen on Mon, Nov 09, 2015:
> > On Mon 2015.11.09 at 00:14 +0100, Vadim Vygonets wrote:
> > > Dear daemonfishes,
> > > 
> > > After using evilwm for a decade, I'm quite impressed with cwm's
> > > codebase and functionality.  (I just couldn't understand one
> > > feature: what's the use of ptrmove* if you cannot click?  (...Mr.
> > > Andersen?))
> > 
> > I've never used this, but maybe someone else cares? The only rationale
> > is that one can move the pointer with the keyboard, then create a new
> > window with a keyboard action.
> 
> Oh.  I just create a window and then move it.
> 
> > Who knows how much this is used, I could go either way.
> 
> Oh no, I'm not proposing to remove anything.

Actually, it barely works today....I suppose it could be fixed...

> > It was excluded from keyboard-based resizing because back then people
> > wanted micro adjustments to windows - something much easier to do with a
> > keyboard than mouse.
> 
> I too want that, though not for xterm.

Well, yes; any client that sets hints - those should be followed.

BTW, in client_getsizehints() we ensure sane hint values, so just adding
one additional check there for min{h,w} would then allow for a simplier
bit in kbfunc, especially if a property is modified:

        if ((cc->geom.w += mx * cc->hint.incw) < cc->hint.minw)
                cc->geom.w = cc->hint.minw;
        if ((cc->geom.h += my * cc->hint.inch) < cc->hint.minh)
                cc->geom.h = cc->hint.minh;

> > If there are objections, no; else, sure, why not.
> 
> Fair enough, thanks!

I'll likely commit the change above along with fixes for kbd pointer
movement (or remove it since no one noticed!)

Thanks,
Okan

Reply via email to