On Wed, Oct 28, 2015 at 06:08:00PM +0100, Alexandr Nedvedicky wrote:
> make implementation of reference handling and further MP stuff bit easier.

I agree that filling the temporary list makes transition to MP
harder.

> Also the patch is part of my effort to kill work queues in radix tables.

For now the code gets more as we have two ways to iterate over the
tree.  When you remove the additional work queues I expect many -
diffs.  So if this code dupliation is temporary, this aproach is
fine for me.

>  #define pfrw_addr    pfrw_1.pfrw1_addr
>  #define pfrw_astats  pfrw_1.pfrw1_astats
>  #define pfrw_workq   pfrw_1.pfrw1_workq
>  #define pfrw_kentry  pfrw_1.pfrw1_kentry
>  #define pfrw_dyn     pfrw_1.pfrw1_dyn
> +#define      pfrw_tzero      pfrw_1.pfrw1_clstat.tzero
> +#define      pfrw_negchange  pfrw_1.pfrw1_clstat.negchange
>  #define pfrw_cnt     pfrw_free

Use space instead of tab after the define.  Otherwise it is incosistent
and the diff looks ugly.

OK bluhm@

Reply via email to