ikectl: ikeca.c cleanup: err/errx usage

[Sebastien Marie]

Hi,

Here a patch that corrects three err() to errx() calls.
  - a if condition don't set errno
  - strlcpy(3) don't set errno (no mention is man page)
  - ca_readpass() already manage errno error message with warn(3)

Comments ? OKs ?
-- 
Sebastien Marie


Index: ikeca.c
===================================================================
RCS file: /cvs/src/usr.sbin/ikectl/ikeca.c,v
retrieving revision 1.30
diff -u -p -r1.30 ikeca.c
--- ikeca.c     16 Jan 2015 06:40:17 -0000      1.30
+++ ikeca.c     12 Aug 2015 06:43:24 -0000
@@ -219,7 +219,7 @@ ca_sign(struct ca *ca, char *keyname, in
                    ca->sslpath, keyname, ca->sslpath, ca->sslpath,
                    ca->extcnf, ca->sslpath, keyname, ca->passfile);
        } else
-               err(1, "unknown host type %d", type);
+               errx(1, "unknown host type %d", type);
 
        system(cmd);
 
@@ -561,7 +561,7 @@ ca_export(struct ca *ca, char *keyname, 
 
        if (keyname != NULL) {
                if (strlcpy(oname, keyname, sizeof(oname)) >= sizeof(oname))
-                       err(1, "name too long");
+                       errx(1, "name too long");
        } else {
                strlcpy(oname, "ca", sizeof(oname));
        }
@@ -758,7 +758,7 @@ ca_revoke(struct ca *ca, char *keyname)
        snprintf(path, sizeof(path), "%s/ikeca.passwd", ca->sslpath);
        pass = ca_readpass(path, &len);
        if (pass == NULL)
-               err(1, "could not open passphrase file");
+               errx(1, "could not open passphrase file");
 
        /* create index if it doesn't already exist */
        snprintf(path, sizeof(path), "%s/index.txt", ca->sslpath);