Those values should not be increased.  The kernel stack should be treated
like a tight resource.

> I added -Winline to the kernel Makefile and got back the following 2
> warnings:
> 
> cc1: warnings being treated as errors
> ../../../../dev/pci/emuxki.c: In function 'emuxki_write_micro':
> ../../../../dev/pci/emuxki.c:633: warning: inlining failed in call to 
> 'emuxki_write': --param inline-unit-growth limit reached
> ../../../../dev/pci/emuxki.c:663: warning: called from here
> *** Error 1 in target 'emuxki.o'
> cc1: warnings being treated as errors
> ../../../../dev/pci/drm/radeon/si.c: In function 'si_irq_suspend':
> ../../../../dev/pci/drm/radeon/si.c:3566: warning: inlining failed in call to 
> 'si_irq_ack': --param max-inline-insns-single limit reached
> ../../../../dev/pci/drm/radeon/si.c:3666: warning: called from here
> *** Error 1 in /usr/src/sys/arch/amd64/compile/GENERIC.MP (Makefile:927 
> 'si.o')
> *** Error 1 (Makefile:927 'emuxki.o')
> 
> emuxki_write fails to be inlined because the function grows > 1.5x the
> original size.
> 
> radeon/si.c fails to be inlined due to too many instructions in a single
> function.
> 
> Are the limits worth increasing or is it not a big deal if these
> particular two functions are not being inlined as thought?
> 
> - David
> 

Reply via email to